Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23264 )
Change subject: IMPALA-14271: Reapply the core piece of IMPALA-6984 ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/23264/4/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/23264/4/be/src/runtime/coordinator-backend-state.cc@725 PS4, Line 725: VLogForBackend(Substitute( > Do we need to mark result.became_done as well? became_done is used to indicate whether to notify a counting barrier. We mostly need it if the regular mechanism won't work (e.g. we cancelled the exec rpc) or this is fire and forget. If IsDoneLocked() is true, then something else already signaled the barrier for this backend (e.g. UpdateBackendExecStatus when ApplyExecStatusReport sees that it is now done and returns true), so we shouldn't signal it here. -- To view, visit http://gerrit.cloudera.org:8080/23264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia058b03c72cc4bb83b0bd0a19ff6c8c43a647974 Gerrit-Change-Number: 23264 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 22 Sep 2025 23:12:34 +0000 Gerrit-HasComments: Yes
