Yida Wu has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/23204 )
Change subject: IMPALA-14234: Fix a version mismatch DCHECK hit when admissiond cluster membership recovering ...................................................................... IMPALA-14234: Fix a version mismatch DCHECK hit when admissiond cluster membership recovering This patch fixes a DCHECK failure in ComputeGroupScheduleStates() for DCHECK_GE(current_membership_version, previous_membership_version) that occurs during cluster membership recovery after a statestore restart. The DCHECK enforces the assumption that the cluster membership version should be monotonically increasing. A new version that is smaller than a version associated with a queued query is considered an abnormal case, which this DCHECK is designed to catch during development. However, during recovery, the new cluster membership version could be lower than the version associated with a queued query, violating the DCHECK condition. To address this, the patch sets the current version to the recovering new cluster membership, ensuring it is not lower than any version stored in queued queries. Tests: Added a regression test in test_dcheck_issue_coord_statestore_kill_order. Change-Id: Iea77347bd4775abd7866817146e326c7c5042f5e --- M be/src/scheduling/cluster-membership-mgr.cc M tests/custom_cluster/test_admission_controller.py 2 files changed, 98 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/23204/6 -- To view, visit http://gerrit.cloudera.org:8080/23204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iea77347bd4775abd7866817146e326c7c5042f5e Gerrit-Change-Number: 23204 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
