Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23466 )
Change subject: IMPALA-14440: Set default http_socket_timeout_s ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/23466/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23466/1//COMMIT_MSG@9 PS1, Line 9: Sets a default http_socket_timeout_s of 600s > Presumably a load balancer would cause similar problems. I can explore it m The more I dig into this, the less I like this option. HS2 uses client_connect_timeout_ms, which it sets on the socket while opening, then removes so later operations don't have a timeout. It has no equivalent to http_socket_timeout_s, which lasts the whole time. What we really want is: 1. Implement HTTP Keep-Alive so we re-use the same TCP connection for multiple HTTP requests and responses. 2. Enable keepalive on the TCP connection (TSocket has a socket_keepalive option). We also want this for HS2-HTTP to detect dead servers connections, rather than using http_socket_timeout_s. 3. Support client_connect_timeout_ms on HS2-HTTP, where we set the timeout during the initial connection open, then remove it. -- To view, visit http://gerrit.cloudera.org:8080/23466 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09f62188552caf65786f57a190722bfe020fc82d Gerrit-Change-Number: 23466 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 02 Oct 2025 23:21:09 +0000 Gerrit-HasComments: Yes
