Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23537
Change subject: IMPALA-14496: Impala crashes when it writes multiple delete files per partition in a single DELETE operation ...................................................................... IMPALA-14496: Impala crashes when it writes multiple delete files per partition in a single DELETE operation Impala crashes when it needs to write multiple delete files per partition in a single DELETE operation. It is because IcebergBufferedDeleteSink has its own DmlExecState object, but sometimes the methods in TableSinkBase use the RuntimeState's DmlExecState object. I.e. it can happen that we add a partition to the IcebergBufferedDeleteSink's DmlExecState, but later we expect to find it in the RuntimeState's DmlExecState. This patch adds new methods to TableSinkBase that are specific for writing delete files, and they always take a DmlExecState object as a parameter. They are now used by IcebergBufferedDeleteSink. Testing * added e2e tests Change-Id: I46266007a6356e9ff3b63369dd855aff1396bb72 --- M be/src/exec/iceberg-buffered-delete-sink.cc M be/src/exec/table-sink-base.cc M be/src/exec/table-sink-base.h A testdata/workloads/functional-query/queries/QueryTest/iceberg-multiple-delete-per-partition.test M tests/query_test/test_iceberg.py 5 files changed, 142 insertions(+), 29 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/23537/1 -- To view, visit http://gerrit.cloudera.org:8080/23537 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I46266007a6356e9ff3b63369dd855aff1396bb72 Gerrit-Change-Number: 23537 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
