Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/6521 )

Change subject: WIP ONLY: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so
......................................................................


Patch Set 4:

(1 comment)

> Patch Set 4:
>
> The build worked on newer linux distros but failed on older ones when 
> building flat buffers:
>
>
> 22:40:05 ./flatc: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version 
> `GLIBCXX_3.4.17' not found (required by ./flatc)

It might be because it's not using the binutil in native-toolchain

http://gerrit.cloudera.org:8080/#/c/6521/4/functions.sh
File functions.sh:

http://gerrit.cloudera.org:8080/#/c/6521/4/functions.sh@490
PS4, Line 490:     if ! local required_libs=$(objdump -p "$file" 2>/dev/null | 
grep NEEDED | awk '{print $2}')
long line



--
To view, visit http://gerrit.cloudera.org:8080/6521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f8481a8dfe35273a763586e9d2da0d4008ac67
Gerrit-Change-Number: 6521
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Tianyi Wang <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 13 Jun 2018 21:17:22 +0000
Gerrit-HasComments: Yes

Reply via email to