Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10630 )
Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/10630/5/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java: http://gerrit.cloudera.org:8080/#/c/10630/5/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@62 PS5, Line 62: fullly > nit: fully Done http://gerrit.cloudera.org:8080/#/c/10630/5/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@87 PS5, Line 87: @param > lets get rid of these (or at least, not add new ones). numClusteringCols is Done http://gerrit.cloudera.org:8080/#/c/10630/5/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@109 PS5, Line 109: FeCatalogUtils. > remove Done http://gerrit.cloudera.org:8080/#/c/10630/5/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java: http://gerrit.cloudera.org:8080/#/c/10630/5/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@191 PS5, Line 191: table-level stats > I see that these are constructed lazily when accessed (L177) whereas other no reason, I'll change that to be eager as well. -- To view, visit http://gerrit.cloudera.org:8080/10630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I640f27e36198955e057da62a3ce25a858406e496 Gerrit-Change-Number: 10630 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Jun 2018 22:50:34 +0000 Gerrit-HasComments: Yes
