Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 )
Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10654/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10654/2//COMMIT_MSG@16 PS2, Line 16: One thing needs extra attention here is that modifying the result of It looks like this adds an extra copy in a lot of cases though, e.g. matchingIds.addAll(tbl_.getPartitionIds()); This may not matter that much, but it's hard to know for sure. What about wrapping it in Collections.unmodifableSet() instead of making a copy: https://docs.oracle.com/javase/7/docs/api/java/util/Collections.html#unmodifiableSet(java.util.Set) -- To view, visit http://gerrit.cloudera.org:8080/10654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b5a480e570aeae565fafd4f3e2b279e7a98c7da Gerrit-Change-Number: 10654 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 13 Jun 2018 23:20:40 +0000 Gerrit-HasComments: Yes
