Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 )
Change subject: IMPALA-6812: Fix flaky Kudu scan tests ...................................................................... Patch Set 3: (1 comment) Thanks for doing this, seems like a really pragmatic solution. Just had one question. http://gerrit.cloudera.org:8080/#/c/10503/3/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/10503/3/tests/query_test/test_kudu.py@310 PS3, Line 310: cursor.execute("set kudu_read_mode=READ_AT_SNAPSHOT") I'm not familiar with the cursor fixture - does it create a new session for every test? Otherwise if it's reused we might end up with the query options leaking into the next test. -- To view, visit http://gerrit.cloudera.org:8080/10503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70df84f2cbc663107f2ad029565d3c15bdfbd47c Gerrit-Change-Number: 10503 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 14 Jun 2018 21:38:15 +0000 Gerrit-HasComments: Yes
