Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 )
Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10704/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10704/2//COMMIT_MSG@23 PS2, Line 23: This was done because the eventual explain plan returned to Can we add a test for this case to parquet-filtering.test? Maybe we can just add a test that points at functional (which has text files) rather than functional_parquet. It would also be good to add a test for a mixed-format table with some parquet to make sure that the predicates are still created in that case. functional.complextypes_multifileformat is the one table we have, I think, but we should probably add more IMPALA-6874 -- To view, visit http://gerrit.cloudera.org:8080/10704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d6c26d42db090c8a15c602f6419ad6399c329e7 Gerrit-Change-Number: 10704 Gerrit-PatchSet: 2 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Jun 2018 00:15:02 +0000 Gerrit-HasComments: Yes
