Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10668 )
Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests ...................................................................... Patch Set 8: (2 comments) I'm basically ready to +2 this. Just a couple things. http://gerrit.cloudera.org:8080/#/c/10668/8/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/10668/8/be/src/exprs/expr-test.cc@7387 PS8, Line 7387: ObjectPool pool; I think this is now unused (and I think clang-tidy might complain). http://gerrit.cloudera.org:8080/#/c/10668/8/be/src/runtime/CMakeLists.txt File be/src/runtime/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10668/8/be/src/runtime/CMakeLists.txt@83 PS8, Line 83: ADD_BE_TEST(data-stream-test) # TODO: this test leaks Is this intended? (i.e. this code change fixes some leaks in data-stream-test.cc, are there more that aren't fixed?) -- To view, visit http://gerrit.cloudera.org:8080/10668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4 Gerrit-Change-Number: 10668 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Jun 2018 19:46:31 +0000 Gerrit-HasComments: Yes
