Hello Tianyi Wang, Vuk Ercegovac,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/10735

to review the following change.


Change subject: IMPALA-7140 (part 4): support creating descriptors for FS tables
......................................................................

IMPALA-7140 (part 4): support creating descriptors for FS tables

This adds the relevant methods to convert LocalFsTable and
LocalFsPartition to thrift descriptors for consumption by the backend.

Unfortunately we cannot yet enable the planner tests, since they are
checking file counts and sizes as part of the explain output, and we
haven't yet implemented file info fetching in the LocalCatalog.

However, I was able to manually test this change by starting an impalad
with --use_local_catalog, connecting to it from the shell, and running
various EXPLAIN SELECT queries against tpch and functional tables. The
explain output is more or less as expected with the exception of missing
file info.

Change-Id: I4550612eb6d1e3a324f49a9c4d24b048e45d3738
---
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/FeFsPartition.java
M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
10 files changed, 223 insertions(+), 105 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/10735/1
--
To view, visit http://gerrit.cloudera.org:8080/10735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4550612eb6d1e3a324f49a9c4d24b048e45d3738
Gerrit-Change-Number: 10735
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>

Reply via email to