Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10493 )
Change subject: IMPALA-110 (part 1): Refactor ExecNode::buffer_pool_client_ ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/10493/2/be/src/runtime/reservation-manager.h File be/src/runtime/reservation-manager.h: http://gerrit.cloudera.org:8080/#/c/10493/2/be/src/runtime/reservation-manager.h@33 PS2, Line 33: which with? http://gerrit.cloudera.org:8080/#/c/10493/2/be/src/runtime/reservation-manager.h@37 PS2, Line 37: static void Register(ReservationManager* rm, std::string name, please document that http://gerrit.cloudera.org:8080/#/c/10493/2/be/src/runtime/reservation-manager.h@39 PS2, Line 39: TBackendResourceProfile resource_profile, const TDebugOptions you probably meant to use references here. http://gerrit.cloudera.org:8080/#/c/10493/2/be/src/runtime/reservation-manager.cc File be/src/runtime/reservation-manager.cc: http://gerrit.cloudera.org:8080/#/c/10493/2/be/src/runtime/reservation-manager.cc@31 PS2, Line 31: Register this looks more like an Init() function (and doesn't have to be static given the first parameters is effectively 'this'). -- To view, visit http://gerrit.cloudera.org:8080/10493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75f92c3f4f05adeef11a70f59e0c8ff2d19bc17a Gerrit-Change-Number: 10493 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Jun 2018 23:47:04 +0000 Gerrit-HasComments: Yes
