Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10740 )
Change subject: IMPALA-7151: Rework ephemeral port assignment for be tests ...................................................................... IMPALA-7151: Rework ephemeral port assignment for be tests Instead of using FindUnusedEphemeralPort() to choose many ephemeral ports for in-process servers, we use Thrift's builtin wildcard ports, where it picks an ephemeral port when the configured port is 0. This should be more robust because there's no window where something else can steal our port. Only Thrift 0.9.2+ support the getPort() method required for this. This does not necessarily make all ImpalaServer functionality work with ports configured to 0, just enough to get expr-test and session-expiry-test to work. E.g. various strings and names get port 0 in them and query execution may not work end-to-end. Some tests still use FindUnusedEphemeralPort() to pick a single port at a time. We haven't seen that usage pattern to be flaky with any frequency and it appears to be more work to fix those, so I left them for now. Testing: Ran core tests. Cherry-picks: not for 2.x Change-Id: I2fcc9243099f8249380ac5f01ac5eb67cba24cf5 --- M be/src/benchmarks/expr-benchmark.cc M be/src/exprs/expr-test.cc M be/src/rpc/rpc-mgr-kerberized-test.cc M be/src/rpc/rpc-mgr-test-base.h M be/src/rpc/rpc-mgr-test.cc M be/src/rpc/thrift-server-test.cc M be/src/rpc/thrift-server.cc M be/src/rpc/thrift-server.h M be/src/runtime/exec-env.cc M be/src/runtime/exec-env.h M be/src/scheduling/scheduler.cc M be/src/scheduling/scheduler.h M be/src/service/client-request-state.cc M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/service/session-expiry-test.cc M be/src/statestore/statestore-subscriber.cc M be/src/statestore/statestore-subscriber.h M be/src/statestore/statestore-test.cc M be/src/testutil/in-process-servers.cc M be/src/testutil/in-process-servers.h M be/src/util/network-util.cc M be/src/util/network-util.h 23 files changed, 169 insertions(+), 127 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/10740/2 -- To view, visit http://gerrit.cloudera.org:8080/10740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2fcc9243099f8249380ac5f01ac5eb67cba24cf5 Gerrit-Change-Number: 10740 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>