Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23857 )
Change subject: IMPALA-12918: Validate numeric values for table stats properties ...................................................................... Patch Set 1: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23857/1/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/23857/1/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@102 PS1, Line 102: TAlterTableSetTblPropertiesParams tblPropertyParams = new TAlterTableSetTblPropertiesParams(); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/23857/1/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@171 PS1, Line 171: String keyForExternalProperty = MetaStoreUtil.findTblPropKeyCaseInsensitive(tblProperties_, "EXTERNAL"); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/23857/1/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@423 PS1, Line 423: boolean containsOrderingProperties = tblProperties.containsKey(AlterTableSortByStmt.TBL_PROP_SORT_ORDER); line too long (109 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e8f2a9784edc86838a375d373e2095dd674d63d Gerrit-Change-Number: 23857 Gerrit-PatchSet: 1 Gerrit-Owner: Kunal Siyag <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 12 Jan 2026 14:21:43 +0000 Gerrit-HasComments: Yes
