Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23867 )
Change subject: IMPALA-14102: [part 3] Modified LoptOptimizeJoinRule with Impala changes ...................................................................... Patch Set 4: (9 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23867/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinHooks.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinHooks.java: http://gerrit.cloudera.org:8080/#/c/23867/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinHooks.java@205 PS4, Line 205: * Return the bitset of the inputrefs used for the given RelNode and its parent's inputref line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23867/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinHooks.java@209 PS4, Line 209: private static ImmutableBitSet getInputRefsForContext(RelNode rel, ImmutableBitSet currentSet, int i) { line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/23867/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinHooks.java@214 PS4, Line 214: // these RelNodes use all of its inputs, so we return the range from 0..size of its line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23867/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinHooks.java@216 PS4, Line 216: return ImmutableBitSet.range(rel.getInputs().get(0).getRowType().getFieldList().size()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23867/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinHooks.java@227 PS4, Line 227: // a filter will use all the inputs from its parent, but will also use any inputrefs line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23867/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinHooks.java@228 PS4, Line 228: // found in the condition. Note, we have to look at the parent of the filter because line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23867/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinHooks.java@229 PS4, Line 229: // if the parent is a project, we only want to use the input fields from the parent line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23867/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinHooks.java@231 PS4, Line 231: return currentSet.union(RelOptUtil.InputFinder.bits(((Filter) rel).getCondition())); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23867/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinHooks.java@233 PS4, Line 233: throw new RuntimeException("Unknown RelNodeType: " + ImpalaPlanRel.getRelNodeType(rel)); line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I525a03d57047a95ece92a258096b4a5e52db331e Gerrit-Change-Number: 23867 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 14 Jan 2026 00:03:39 +0000 Gerrit-HasComments: Yes
