Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23868 )
Change subject: IMPALA-14102: [part 4] Account for Runtime Filter application in cost model ...................................................................... Patch Set 3: (5 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23868/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinHooks.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinHooks.java: http://gerrit.cloudera.org:8080/#/c/23868/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinHooks.java@589 PS3, Line 589: int endIndex = startIndex + multiJoin_.getInputs().get(factor).getRowType().getFieldList().size(); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/23868/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdColumnOrigins.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdColumnOrigins.java: http://gerrit.cloudera.org:8080/#/c/23868/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdColumnOrigins.java@78 PS3, Line 78: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaRelMdColumnOrigins.class.getName()); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/23868/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdColumnOrigins.java@97 PS3, Line 97: return mq.getColumnOrigins(rel.getInput(), rel.getGroupSet().asList().get(iOutputColumn)); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23868/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdColumnOrigins.java@212 PS3, Line 212: public @Nullable Set<RelColumnOrigin> getColumnOrigins(TableModify rel, RelMetadataQuery mq, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23868/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdColumnOrigins.java@320 PS3, Line 320: private static @Nullable Set<RelColumnOrigin> getMultipleColumns(RexNode rexNode, RelNode input, line too long (98 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32abe5b02cb9d63bf226a4f4dfe3b458cf6b947d Gerrit-Change-Number: 23868 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 14 Jan 2026 00:06:21 +0000 Gerrit-HasComments: Yes
