Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/23873 )
Change subject: IMPALA-14682: Use centralized async cleanup for admission state cleanup ...................................................................... IMPALA-14682: Use centralized async cleanup for admission state cleanup In IMPALA-14605, we aded a mechanism to clean up the admission state asynchronously. This patch refactors all admission state deletions to use this centralized async method, making it easier to reason about when admission state is removed and to detect cases where a query’s admission state is not properly cleared. Additionally, this refactoring is a necessary step for future improvements, such as implementing time-based deletion. Also updated test_admission_state_map_mem_leak to verify the admission state number using the new global metric admission-control-service.num-queries as it is more stable than checking the log. Tests: Passed core tests. Passed exhaustive custom_cluster/test_admission_controller.py test. Change-Id: I04f46f2e42ec5e50f4dcccb6b73a34a376615ab0 --- M be/src/scheduling/admission-control-service.cc M be/src/scheduling/admission-control-service.h M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/scheduling/admissiond-env.cc M tests/custom_cluster/test_admission_controller.py 6 files changed, 24 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/23873/2 -- To view, visit http://gerrit.cloudera.org:8080/23873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04f46f2e42ec5e50f4dcccb6b73a34a376615ab0 Gerrit-Change-Number: 23873 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
