Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23874 )
Change subject: IMPALA-14629: Implement st_point(double,double) in c++ ...................................................................... IMPALA-14629: Implement st_point(double,double) in c++ Adds native implementation for the common 2d constructor while keeps the more complex st_point(string) in Java. Tried using boost's WKT parser but making it work with >2d geometries seemed non-trivial. Also removes the following overloads: st_point(double,double,double) st_point(double,double,double,double) st_pointz(double,double,double,double) These conflict with overloads that have different semantics in PostGis, see HIVE-29395 for details. Testing: - no test changes are needed - the remaining constructors are covered while the removed ones were not used at all Change-Id: I927413f92cf4d4e9a995f7024de0ec2e3b584b6d Reviewed-on: http://gerrit.cloudera.org:8080/23874 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exprs/geo/geospatial-functions-ir.cc M be/src/exprs/geo/geospatial-functions.h M be/src/exprs/geo/shape-format.h M fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java M testdata/workloads/functional-query/queries/QueryTest/geospatial-esri-planner.test 5 files changed, 58 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I927413f92cf4d4e9a995f7024de0ec2e3b584b6d Gerrit-Change-Number: 23874 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]>
