Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23679 )
Change subject: IMPALA-14525: Calcite planner: Add support for RexSimplify ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/23679/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaCoreRules.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaCoreRules.java: http://gerrit.cloudera.org:8080/#/c/23679/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaCoreRules.java@60 PS7, Line 60: public static final RelBuilderFactory LOGICAL_BUILDER_NO_SIMPLIFY = > Agreed..let's remove the ones that can be picked up directly from Calcite. Ok, as I went to remove it, I now remember why I did it this way... The RelBuilder.filter() (and others) method calls simplifyFilterPredicates which calls simplify. That basically means that anytime a Filter RelNode gets instantiated or potentially recreated through the RelBuilder, the simplify method gets called. I think this is true for Projects and Joins as well. This method is used in many places. That leaves us a second option though: We could provide our own RelBuilder. But there would be a lot of duplicated logic whereas this way, it is just a configuration. -- To view, visit http://gerrit.cloudera.org:8080/23679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44792688f361bf15affa565e5de5709f64dcf18c Gerrit-Change-Number: 23679 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 19 Jan 2026 17:28:14 +0000 Gerrit-HasComments: Yes
