Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23475 )
Change subject: IMPALA-14467: Support quoted keys with dots in get_json_object path strings ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/23475/7/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/23475/7/be/src/exprs/string-functions.cc@368 PS7, Line 368: constexpr char quote_char = '"'; > nit: constexpr before the loop? Done http://gerrit.cloudera.org:8080/#/c/23475/7/be/src/exprs/string-functions.cc@370 PS7, Line 370: int consumed = ParseQuotedString(path + i, path_end, quote_char, &key); > nit: indentation is off by 2 Done http://gerrit.cloudera.org:8080/#/c/23475/7/be/src/exprs/string-functions.cc@371 PS7, Line 371: : string msg = Substitute("Failed to parse quoted > nit: indentation for additional param should be 4 Done http://gerrit.cloudera.org:8080/#/c/23475/7/be/src/util/string-util.cc File be/src/util/string-util.cc: http://gerrit.cloudera.org:8080/#/c/23475/7/be/src/util/string-util.cc@97 PS7, Line 97: if (start == nullptr || end == nullptr || result == nullptr || start >= end) { > Please move this after the null-check, or is this required at all? Done http://gerrit.cloudera.org:8080/#/c/23475/7/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: http://gerrit.cloudera.org:8080/#/c/23475/7/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3143 PS7, Line 3143: Verify that > nit: usually, we add the ticket number to a test if it's a fix for regressi Done -- To view, visit http://gerrit.cloudera.org:8080/23475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3618d9e029501f9ac0e23190feb8263968b1b9f Gerrit-Change-Number: 23475 Gerrit-PatchSet: 8 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 20 Jan 2026 17:37:54 +0000 Gerrit-HasComments: Yes
