Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23857 )
Change subject: IMPALA-12918: Validate numeric values for table stats properties ...................................................................... Patch Set 3: (3 comments) Thank you for your interest in the project! Before uploading a patch, please consider the ASF Generative Tooling Guidance: https://www.apache.org/legal/generative-tooling.html If you are using AI, please do your best to review the code first; e.g. avoid committing any unnecessary reformatting of already existing code. http://gerrit.cloudera.org:8080/#/c/23857/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/23857/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@410 PS3, Line 410: /** : * Analyzes the 'sort.columns' property in 'tblProperties' against the columns : * of : * 'table'. The property must store a list of column names separated by commas, : * and each : * column in the property must occur in 'table' as a non-partitioning column. If : * there : * are errors during the analysis, this function will throw an : * AnalysisException. : * Returns a pair of list of positions of the sort columns within the table's : * list of : * columns and the corresponding sorting order. : */ We wrap lines at 90 characters. Please remove any reformatting of code lines you did not need to change. http://gerrit.cloudera.org:8080/#/c/23857/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@464 PS3, Line 464: Validates that table stats properties (numRows, totalSize, rawDataSize) : * contain nit: fits in one line http://gerrit.cloudera.org:8080/#/c/23857/3/fe/src/test/java/org/apache/impala/analysis/TableStatsValidationBugTest.java File fe/src/test/java/org/apache/impala/analysis/TableStatsValidationBugTest.java: http://gerrit.cloudera.org:8080/#/c/23857/3/fe/src/test/java/org/apache/impala/analysis/TableStatsValidationBugTest.java@26 PS3, Line 26: public class TableStatsValidationBugTest extends FrontendTestBase { No need for adding this new class. Extend the already existing AnalyzeDDLStmtsTest with these test cases. -- To view, visit http://gerrit.cloudera.org:8080/23857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e8f2a9784edc86838a375d373e2095dd674d63d Gerrit-Change-Number: 23857 Gerrit-PatchSet: 3 Gerrit-Owner: Kunal Siyag <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kunal Siyag <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 21 Jan 2026 10:07:30 +0000 Gerrit-HasComments: Yes
