Yida Wu has uploaded a new patch set (#3). ( 
http://gerrit.cloudera.org:8080/23881 )

Change subject: IMPALA-14267: Reduce log frequency when dequeuing fails
......................................................................

IMPALA-14267: Reduce log frequency when dequeuing fails

When the admission controller fails to dequeue queries, like when at
capacity, it logs a message on every retry loop. This can cause
excessive logs, like ten per second until queuing timeout.

This patch reduces the log frequency to once every 5 seconds using
KLOG_EVERY_N_SECS. This prevents too many logs while keeping the
message visible when admission control is at capacity.

This also changes the dequeuing fails log level from VLOG(1) to INFO
because the macro uses a standard log level, but this is safe because
the log rate is under control now.

Testing:
Verified logs are throttled to 5s intervals when the queue is full.

Change-Id: I682b4416a2255f5be6480a7db8835f6aa54477bb
---
M be/src/scheduling/admission-controller.cc
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/23881/3
--
To view, visit http://gerrit.cloudera.org:8080/23881
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I682b4416a2255f5be6480a7db8835f6aa54477bb
Gerrit-Change-Number: 23881
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>

Reply via email to