Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23852 )
Change subject: IMPALA-14661: Optimize admissiond memory usage by compressing exec requests ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/23852/5/be/src/rpc/thrift-util.h File be/src/rpc/thrift-util.h: http://gerrit.cloudera.org:8080/#/c/23852/5/be/src/rpc/thrift-util.h@285 PS5, Line 285: const uint8_t* serialized_buf, uint32_t serialized_len, TCompressed* dest) { : DCHECK(serialized_buf != nullptr); : DCHECK(dest != nullptr); : > We use cached compressor/decompressor in the Table writer/reader since that That makes sense. I agree that caching is better for high frequency paths. Since this is only used for large requests above a specific threshold, the frequency should be low, and the performance impact of creating a new compressor is minimal. Given the urgency, I prefer to avoid the extra complexity of caching right now to ensure safety. I will file a follow-up jira for optimization later http://gerrit.cloudera.org:8080/#/c/23852/8/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/23852/8/be/src/scheduling/admission-controller.h@86 PS8, Line 86: const TQueryExecRequest* request() const override { > Are we actually using the fast accessor in the code? Yeah, it is used in remote-admission-control-client.cc. We use it there to pass around the original TQueryExecRequest before it sent out from the client side. Using request() makes the code simpler -- To view, visit http://gerrit.cloudera.org:8080/23852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a676d1a806451cbf84b0a3f8a706d7c6655e12d Gerrit-Change-Number: 23852 Gerrit-PatchSet: 8 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 22 Jan 2026 23:26:24 +0000 Gerrit-HasComments: Yes
