Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21530 )
Change subject: IMPALA-13166: Speed up getFullyQualifiedRawPath ...................................................................... IMPALA-13166: Speed up getFullyQualifiedRawPath Caches getFullyQualifiedRawPath for repeat calls, and uses Arrays.asList to avoid copying primitive arrays. Returns an ImmutableList as more compact than an ArrayList. Implements equals and hashCode on Path to provide a cleaner interface for lookups on Path. Speeds up PlannerTest#testManyExpressionPerformance from 21s to 18s in local testing. Change-Id: If02d3b20a980508deafd2109a10676ab01e50981 Reviewed-on: http://gerrit.cloudera.org:8080/21530 Reviewed-by: Michael Smith <[email protected]> Tested-by: Michael Smith <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java M fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java M fe/src/main/java/org/apache/impala/analysis/Path.java M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java 5 files changed, 84 insertions(+), 63 deletions(-) Approvals: Michael Smith: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If02d3b20a980508deafd2109a10676ab01e50981 Gerrit-Change-Number: 21530 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
