Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21531 )
Change subject: IMPALA-13166: Improve lookup of existing slot descriptors ...................................................................... IMPALA-13166: Improve lookup of existing slot descriptors Improves lookup for existing SlotDescriptors created by another Analyzer by maintaining a map of Path to SlotDescriptor in TupleDescriptor. Only adds entries that are also inserted into slotPathMap_. Moves expensive lower-case slot path precondition to happen only when adding new slot descriptors. Speeds up PlannerTest#testManyExpressionPerformance by 1-2s (5-10%) in local testing. Change-Id: Id904ee8a641fb06ebca95b53ea29e78d120a2288 Reviewed-on: http://gerrit.cloudera.org:8080/21531 Reviewed-by: Michael Smith <[email protected]> Tested-by: Michael Smith <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java 2 files changed, 27 insertions(+), 17 deletions(-) Approvals: Michael Smith: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id904ee8a641fb06ebca95b53ea29e78d120a2288 Gerrit-Change-Number: 21531 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
