Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23884 )
Change subject: IMPALA-14673 impala-shell: profile format argument ...................................................................... Patch Set 4: > Hello, thank you for working on this. It is good to have the > thrift/base64 option. > > To allow easier access to the profile, without having to scroll > through and copying the large text from impala-shell... > > I was thinking it would be more accessible if we could provide the > thrift profile download link for the webUI, or the curl command. > > Another option would be to write it to a file(possibly within the > current directory) with impala-shell. > > Basically, it is better to directly have it as a file then making > the user to copy it each time. > > This is also true because there is no easy way to pipe the output > of profile command into a file from impala-shell(like with >> in > bash/sh) for just the profile command without having other outputs > as well. > > Initially, when we had discussed Csaba and me had decided to > provide the user with the relevant curl command to download the > thrift when requested, please let me know if this is better. > Hello, thank you for working on this. It is good to have the > thrift/base64 option. > > To allow easier access to the profile, without having to scroll > through and copying the large text from impala-shell... > > I was thinking it would be more accessible if we could provide the > thrift profile download link for the webUI, or the curl command. > > Another option would be to write it to a file(possibly within the > current directory) with impala-shell. > > Basically, it is better to directly have it as a file then making > the user to copy it each time. > > This is also true because there is no easy way to pipe the output > of profile command into a file from impala-shell(like with >> in > bash/sh) for just the profile command without having other outputs > as well. > > Initially, when we had discussed Csaba and me had decided to > provide the user with the relevant curl command to download the > thrift when requested, please let me know if this is better. There is another patch by Balazs about printing the profile to a file: https://gerrit.cloudera.org/#/c/23883/ I agree that printing the base64 encoded Thrift to stdout is not that useful, so writing to a file would be the main use case. About providing a link: we already provide a link in Impala shell to fetch more info about it in webui - someone experienced with Impala should be able to download the profile based on that. There can be also cases when the webui is not accessible, e.g. the port is not forwarded or the user has no privileges to see the webui, and in this case fetching the profile through the hs2/beeswax client is the only option -- To view, visit http://gerrit.cloudera.org:8080/23884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I032a5d0436f123d737d46d0b8cecbae09888a789 Gerrit-Change-Number: 23884 Gerrit-PatchSet: 4 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 23 Jan 2026 17:31:55 +0000 Gerrit-HasComments: No
