Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 )
Change subject: IMPALA-6969: add AC last queued cause to profile ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/10731/3/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/10731/3/be/src/scheduling/admission-controller.cc@110 PS3, Line 110: Admission queue details" so the reason given in this entry will always be the initial reason, is that right? Will it be clear what this entry means vs the new entry? http://gerrit.cloudera.org:8080/#/c/10731/3/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/10731/3/tests/custom_cluster/test_admission_controller.py@604 PS3, Line 604: EXPECTED_CAUSE = \ for these tests, do you think it's also worth verifying that the initial reason is as expected? -- To view, visit http://gerrit.cloudera.org:8080/10731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida9b75dc50dfb7a27f59deda91bad6ac838130a1 Gerrit-Change-Number: 10731 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 18 Jun 2018 21:16:14 +0000 Gerrit-HasComments: Yes
