Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23905 )
Change subject: WIP IMPALA-12844 Support setting DBPROPERTIES ...................................................................... Patch Set 1: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23905/1/fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbpropertiesStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbpropertiesStmt.java: http://gerrit.cloudera.org:8080/#/c/23905/1/fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbpropertiesStmt.java@44 PS1, Line 44: super(dbName); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23905/1/fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbpropertiesStmt.java@74 PS1, Line 74: TAlterDbSetDbpropertiesParams setDbpropertiesParams = new TAlterDbSetDbpropertiesParams(); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23905/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/23905/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@8410 PS1, Line 8410: long newCatalogVersion = catalog_.incrementAndGetCatalogVersion(); line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/23905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I628c7bed4f0c39aed7f5f4ffea52421caf501933 Gerrit-Change-Number: 23905 Gerrit-PatchSet: 1 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 26 Jan 2026 14:32:16 +0000 Gerrit-HasComments: Yes
