Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23793 )
Change subject: IMPALA-14092 Part3: Enable predicate pushdown for paimon table. ...................................................................... Patch Set 6: (4 comments) Left a few small comments, otherwise LGTM! http://gerrit.cloudera.org:8080/#/c/23793/4/fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java File fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java: http://gerrit.cloudera.org:8080/#/c/23793/4/fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java@194 PS4, Line 194: > indexOf("%") returned the last character at L191, so this should be always This comment was not resolved. http://gerrit.cloudera.org:8080/#/c/23793/4/fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java@199 PS4, Line 199: > lastIndexOf() returned 0 above, so this should be always true. This comment was not resolved. http://gerrit.cloudera.org:8080/#/c/23793/6/fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java File fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java: http://gerrit.cloudera.org:8080/#/c/23793/6/fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java@111 PS6, Line 111: " Would it be possible to output the compoundPredicate? So users will know which predicate is the problem. http://gerrit.cloudera.org:8080/#/c/23793/4/fe/src/main/java/org/apache/impala/planner/paimon/PredicateExtractor.java File fe/src/main/java/org/apache/impala/planner/paimon/PredicateExtractor.java: http://gerrit.cloudera.org:8080/#/c/23793/4/fe/src/main/java/org/apache/impala/planner/paimon/PredicateExtractor.java@90 PS4, Line 90: postScanExprs_.add(expr); > Paimon partition design is similar to hive, it does't have partition specs So my understanding is that exprs in pushedExprs_ are evaluated by the Java Paimon scanner. And exprs in postScanExprs_ are evaluated in our C++ scanner after the Java scanner returned. So, since 'expr' is already added to pushedExprs_, is it necessary to add it to postScanExprs_? Or is my understanding incorrect? -- To view, visit http://gerrit.cloudera.org:8080/23793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee07fa35de8381121a20b2976d6424626d705483 Gerrit-Change-Number: 23793 Gerrit-PatchSet: 6 Gerrit-Owner: ji chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: ji chen <[email protected]> Gerrit-Comment-Date: Tue, 27 Jan 2026 17:12:35 +0000 Gerrit-HasComments: Yes
