Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23723 )
Change subject: IMPALA-13712: Calcite Planner - Enable constant folding ...................................................................... Patch Set 8: (1 comment) Yes, this does replace now() http://gerrit.cloudera.org:8080/#/c/23723/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaRexExecutor.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaRexExecutor.java: http://gerrit.cloudera.org:8080/#/c/23723/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaRexExecutor.java@292 PS8, Line 292: 65536 > Nit: Should we use LiteralExpr.MAX_STRING_LITERAL_SIZE here instead? Done -- To view, visit http://gerrit.cloudera.org:8080/23723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98c21ef75b2f5f8e3390ff5de5fdf45d9645b326 Gerrit-Change-Number: 23723 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 28 Jan 2026 14:44:38 +0000 Gerrit-HasComments: Yes
