Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources ...................................................................... Patch Set 3: (2 comments) Thanks for applying the changes! One note about the new patch set: if you rebase your code to master, it's better practice to push the rebase and fixes in separate patch sets, so it is easier to see what changes are relevant to your CR. E.g. now if you compare PS 3 and 4, you can see a lot of noise were added from the rebase http://gerrit.cloudera.org:8080/#/c/23733/4/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/23733/4/docs/topics/impala_iceberg.xml@1103 PS4, Line 1103: <li> : <codeph>iceberg.io-impl</codeph>: custom FileIO implementation to use in a : catalog. Must be set to enable manifest caching. Impala def Having Complex types here might suggest that CREATE TABLE LIKE statements don't work with complex types. So I think this part can be removed, as it is a limitation of write operations, not a limitation of CREATE TABLE LIKE. http://gerrit.cloudera.org:8080/#/c/23733/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java: http://gerrit.cloudera.org:8080/#/c/23733/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@178 PS3, Line 178: // Note: Creating non-Iceberg tables from Iceberg sources works : // Validate that JDBC and Paimon tables cannot be used as source > Yes, we do have a bug, creating non-Iceberg from Iceberg does incorrectly c Thanks for fixing the bug! Can we move the check to this file, so we can catch the non-supported case during analysis? -- To view, visit http://gerrit.cloudera.org:8080/23733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e Gerrit-Change-Number: 23733 Gerrit-PatchSet: 3 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 29 Jan 2026 13:01:23 +0000 Gerrit-HasComments: Yes
