Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23897 )
Change subject: IMPALA-14693: Document Iceberg REST Catalog support ...................................................................... Patch Set 3: (7 comments) Thanks for writing these docs! http://gerrit.cloudera.org:8080/#/c/23897/2/docs/topics/impala_iceberg_rest_catalog.xml File docs/topics/impala_iceberg_rest_catalog.xml: http://gerrit.cloudera.org:8080/#/c/23897/2/docs/topics/impala_iceberg_rest_catalog.xml@89 PS2, Line 89: .properties I don't think we make this restriction in our code: https://github.com/apache/impala/blob/593b0bfad3e04d83193f599bc274e873235cebeb/fe/src/main/java/org/apache/impala/service/catalogmanager/ConfigLoader.java#L54 http://gerrit.cloudera.org:8080/#/c/23897/2/docs/topics/impala_iceberg_rest_catalog.xml@90 PS2, Line 90: Location: Directory specified by <codeph>--catalog_config_dir</codeph> flag</li> It is already mentioned above. http://gerrit.cloudera.org:8080/#/c/23897/2/docs/topics/impala_iceberg_rest_catalog.xml@91 PS2, Line 91: Format: Standard Java Properties with key=value pairs It is a bit redundant under the section "...standard Java Properties format..." http://gerrit.cloudera.org:8080/#/c/23897/2/docs/topics/impala_iceberg_rest_catalog.xml@149 PS2, Line 149: oauth2 iceberg.rest-catalog.security=OAUTH2 and iceberg.rest-catalog.oauth2.server-uri properties could be also mentioned http://gerrit.cloudera.org:8080/#/c/23897/2/docs/topics/impala_iceberg_rest_catalog.xml@176 PS2, Line 176: Catalog This mode also supports multiple REST Catalogs. http://gerrit.cloudera.org:8080/#/c/23897/2/docs/topics/impala_iceberg_rest_catalog.xml@231 PS2, Line 231: <title>Mode 3: Multiple REST Catalogs</title> I think Mode 2 and Mode 3 could be merged: One or more REST Catalogs + HMS http://gerrit.cloudera.org:8080/#/c/23897/2/docs/topics/impala_iceberg_rest_catalog.xml@301 PS2, Line 301: Write Operations:</b> Write operations (INSERT, UPDATE, DELETE, MERGE) are not supported. DDL operations are not supported either. -- To view, visit http://gerrit.cloudera.org:8080/23897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a125bfcd5c4058f6cbcd81b8d56c0571a06981d Gerrit-Change-Number: 23897 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 29 Jan 2026 13:25:57 +0000 Gerrit-HasComments: Yes
