Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 )
Change subject: IMPALA-6969: add AC last queued cause to profile ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/10731/6/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/10731/6/be/src/scheduling/admission-controller.cc@110 PS6, Line 110: const string PROFILE_INFO_KEY_INITIAL_QUEUE_CAUSE = "Initial admission queue cause"; : const string PROFILE_INFO_VAL_INITIAL_QUEUE_CAUSE = "waited $0 ms, reason: $1"; : const string PROFILE_INFO_KEY_LAST_QUEUED_CAUSE = "Latest admission queue cause"; How about: "Initial Queuing Reason" "Latest Queuing Reason" I am also ok with going ahead with the current one. -- To view, visit http://gerrit.cloudera.org:8080/10731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida9b75dc50dfb7a27f59deda91bad6ac838130a1 Gerrit-Change-Number: 10731 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Jun 2018 15:02:51 +0000 Gerrit-HasComments: Yes
