Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23987 )
Change subject: IMPALA-14749: Fix warning with Python 3.12 ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+1 > > lgtm, but as Joe wrote, we should come to an agreement about bumping other > uses of Thrift > > I checked Thrift's CHANGELOG and Jira, and based on those there are very few > differences in Python compilation > https://issues.apache.org/jira/browse/THRIFT-5885?jql=project%20%3D%20THRIFT%20AND%20fixVersion%20in%20(0.23.0%2C%200.17.0%2C%200.18.0%2C%200.18.1%2C%200.19.0%2C%200.20.0%2C%200.21.0%2C%200.22.0)%20AND%20component%20%3D%20%22Python%20-%20Compiler%22 > > The biggest one seems type hinting, but probably that doesn't change > compatibility with the lib. > > So I am ok with keeping the old generator and use it with the new python > library as long as tests pass. Later we could bump c++ and Java Thrift lib > too together with the generator (probably when 0.23 is released) I'll put up a patch to add Thrift 0.22.0 to native-toolchain, but I don't see any likely incompatibility. I used the Thrift 0.22.0 Python generator and compared the output (after auto-formatting, because there were some formatting changes). The only differences were a few new lines in 0.22.0: * from uuid import UUID * thrift_spec = None * self.validate() -- To view, visit http://gerrit.cloudera.org:8080/23987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1dbbe1b12dc954725bafa55ec5c4b790db9c1b7 Gerrit-Change-Number: 23987 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 18 Feb 2026 17:12:54 +0000 Gerrit-HasComments: No
