Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23982 )
Change subject: IMPALA-14738: Adds basic testing for Iceberg V3 tables ...................................................................... Patch Set 2: (1 comment) Thanks for working on this, it'll really help with the v3 development. http://gerrit.cloudera.org:8080/#/c/23982/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/23982/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@265 PS2, Line 265: if (field.initialDefaultLiteral() != null) { We are checking this only for the materialised SlotRefs right? Not sure but could there be some case where the query doesn't materialise a column allowing scans that should likely be rejected? -- To view, visit http://gerrit.cloudera.org:8080/23982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1b90f1af539731d4653e83b848d55517a3acb58 Gerrit-Change-Number: 23982 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 18 Feb 2026 17:41:44 +0000 Gerrit-HasComments: Yes
