Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/23932 )
Change subject: IMPALA-12374: Optimize trailing/leading % in LIKE ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/23932/10/be/src/exprs/like-predicate-test.cc File be/src/exprs/like-predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/23932/10/be/src/exprs/like-predicate-test.cc@26 PS10, Line 26: class LikePredicateTests { > Nit: Googletest has some options for organizing tests into classes so they Thanks for the information. Using a wrapper class makes it easier to reach members declared private in LikePredicate (e.g. functions inside LikePredicate::LikePredicateState) by declaring it a friend of class LikePredicate. I find this to be the simplest solution. I rewrote it a bit so that the assertions for different test cases are in different lines, so a failed case can be easily identified. http://gerrit.cloudera.org:8080/#/c/23932/10/be/src/exprs/like-predicate-test.cc@35 PS10, Line 35: // Check that constant strings (with leading/tra > Thanks for adding this test. Let's go ahead and test the edge cases like es Done -- To view, visit http://gerrit.cloudera.org:8080/23932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37b472e056f791035d25633f17ad8a6e841cdd18 Gerrit-Change-Number: 23932 Gerrit-PatchSet: 11 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Thu, 19 Feb 2026 08:14:41 +0000 Gerrit-HasComments: Yes
