Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24001 )
Change subject: IMPALA-14737: Push down LIKE predicates to Iceberg ...................................................................... Patch Set 2: (4 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/24001/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24001/2//COMMIT_MSG@23 PS2, Line 23: - 'exact' - no wildcard (should use = instead) We should pushdown it with Expressions.equal(). http://gerrit.cloudera.org:8080/#/c/24001/2/fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java File fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java: http://gerrit.cloudera.org:8080/#/c/24001/2/fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java@160 PS2, Line 160: String sql = predicate.toSql(); : if (!sql.contains(" LIKE ")) { : throw new ImpalaRuntimeException(String.format( : "Only LIKE operator is supported for Iceberg pushdown: %s", sql)); : } Instead of string matching, we should check that predicate.getOp() == LIKE. http://gerrit.cloudera.org:8080/#/c/24001/2/fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java@213 PS2, Line 213: 'abc' -> null (no wildcard, should use = instead) As mentioned in the commit message, we should just do this for the user: string_col LIKE 'abc' => push down string_col = 'abc' http://gerrit.cloudera.org:8080/#/c/24001/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-like-pushdown.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-like-pushdown.test: http://gerrit.cloudera.org:8080/#/c/24001/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-like-pushdown.test@194 PS2, Line 194: ==== Please add tests for: * LIKE 'click' * strings with UTF-8 characters * BINARY column (Type.isStringType() return true for BINARY) -- To view, visit http://gerrit.cloudera.org:8080/24001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I548834126540bcc8d22efc872c2571293b8b7ec4 Gerrit-Change-Number: 24001 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 19 Feb 2026 17:35:29 +0000 Gerrit-HasComments: Yes
