Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23990 )

Change subject: IMPALA-14764 (part 1): Vendor LLVM's run-clang-tidy.py
......................................................................


Patch Set 4:

(6 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23990/4/bin/llvm/run-clang-tidy.py
File bin/llvm/run-clang-tidy.py:

http://gerrit.cloudera.org:8080/#/c/23990/4/bin/llvm/run-clang-tidy.py@63
PS4, Line 63: r
flake8: E501 line too long (99 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/23990/4/bin/llvm/run-clang-tidy.py@253
PS4, Line 253: a
flake8: E501 line too long (103 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/23990/4/bin/llvm/run-clang-tidy.py@271
PS4, Line 271: -
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/23990/4/bin/llvm/run-clang-tidy.py@302
PS4, Line 302:
flake8: E501 line too long (97 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/23990/4/bin/llvm/run-clang-tidy.py@625
PS4, Line 625: f
flake8: E501 line too long (114 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/23990/4/bin/llvm/run-clang-tidy.py@731
PS4, Line 731: t
flake8: E501 line too long (102 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/23990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia409d0bcdaefc93b81d1f3df278b2e4258122f9c
Gerrit-Change-Number: 23990
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Fri, 20 Feb 2026 18:30:00 +0000
Gerrit-HasComments: Yes

Reply via email to