Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23793 )
Change subject: IMPALA-14092 Part3: Enable predicate pushdown for paimon table. ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/23793/8/fe/src/test/java/org/apache/impala/planner/paimon/PaimonImpalaExprConverterTest.java File fe/src/test/java/org/apache/impala/planner/paimon/PaimonImpalaExprConverterTest.java: http://gerrit.cloudera.org:8080/#/c/23793/8/fe/src/test/java/org/apache/impala/planner/paimon/PaimonImpalaExprConverterTest.java@241 PS8, Line 241: String.format("select * from %s where %s like 'aaa%%bbb'", TBL, col), : PREDICATE_OP.STARTS_ENDS_WITH, "aaa", "bbb"); > Can you add test for 'aaa%bbb%ccc'? Also for 'aaa_bbb_ccc', and 'aaa_b%c_d% Though if for 'aaa%bbb%ccc', we pushdown the followings: * startsWith('aaa'); * endsWith('ccc'); We need to make sure that the full LIKE 'aaa%bbb%ccc' still gets evaluated by the scanners. -- To view, visit http://gerrit.cloudera.org:8080/23793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee07fa35de8381121a20b2976d6424626d705483 Gerrit-Change-Number: 23793 Gerrit-PatchSet: 8 Gerrit-Owner: ji chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: ji chen <[email protected]> Gerrit-Comment-Date: Mon, 23 Feb 2026 10:04:11 +0000 Gerrit-HasComments: Yes
