Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23997 )
Change subject: IMPALA-14754: Allow GCM encryption without PCLMULQDQ ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Thanks for the fix! http://gerrit.cloudera.org:8080/#/c/23997/3/testdata/workloads/functional-query/queries/QueryTest/encryption_exprs_aes_256_gcm.test File testdata/workloads/functional-query/queries/QueryTest/encryption_exprs_aes_256_gcm.test: http://gerrit.cloudera.org:8080/#/c/23997/3/testdata/workloads/functional-query/queries/QueryTest/encryption_exprs_aes_256_gcm.test@34 PS3, Line 34: consistantly nit: consistently http://gerrit.cloudera.org:8080/#/c/23997/3/testdata/workloads/functional-query/queries/QueryTest/encryption_exprs_aes_256_gcm.test@129 PS3, Line 129: AES_256_GCM or AES_256_CFB Isn't CTR also a possible default mode? See EncryptionKey::GetSupportedDefaultMode() -- To view, visit http://gerrit.cloudera.org:8080/23997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6353fb9a686046274f1cbde79ecda7aa46adf0b Gerrit-Change-Number: 23997 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Mon, 23 Feb 2026 12:34:39 +0000 Gerrit-HasComments: Yes
