Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23906 )
Change subject: IMPALA-13122: Add detailed file metadata statistics to table loading logs ...................................................................... Patch Set 6: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23906/2/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java File fe/src/main/java/org/apache/impala/catalog/FeFsTable.java: http://gerrit.cloudera.org:8080/#/c/23906/2/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java@124 PS2, Line 124: // Max access time : public long maxAccessTime = 0; : // Set of unique host:disk pairs (for HDFS/Ozone only) : // Stores pairs as Pair<hostIndex, diskId> for eff > Done >Just replace this with host:disk pairs. Shouldn't we also print the number of host? http://gerrit.cloudera.org:8080/#/c/23906/6/tests/custom_cluster/test_file_metadata_stats.py File tests/custom_cluster/test_file_metadata_stats.py: http://gerrit.cloudera.org:8080/#/c/23906/6/tests/custom_cluster/test_file_metadata_stats.py@33 PS6, Line 33: (HDFS/Ozone only) I don't see any skipIf markers that should allow skipping these tests on S3 -- To view, visit http://gerrit.cloudera.org:8080/23906 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f4592f173c047e5064058402f83be6d1f5c9a79 Gerrit-Change-Number: 23906 Gerrit-PatchSet: 6 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 23 Feb 2026 17:41:24 +0000 Gerrit-HasComments: Yes
