Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23967 )
Change subject: IMPALA-14620 (part 1): Remove the Python 2 impala-python virtualenv ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/23967/10/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/23967/10/bin/impala-config.sh@193 PS10, Line 193: unset IMPALA_PYTHON_URL > Why is this IMPALA_PYTHON_URL and not IMPALA_PYTHON3_URL? bin/bootstrap_toolchain.py considers this the "python" package, so it looks at IMPALA_PYTHON_* variables. We're doing a custom version looking at IMPALA_PYTHON3_VERSION, but it still expects IMPALA_PYTHON_URL. Now that I think about this, I should switch to having IMPALA_PYTHON_VERSION be the python 3 version. That would clean up bin/bootstrap_toolchain.py and avoid the custom code. -- To view, visit http://gerrit.cloudera.org:8080/23967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a Gerrit-Change-Number: 23967 Gerrit-PatchSet: 10 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 24 Feb 2026 01:07:18 +0000 Gerrit-HasComments: Yes
