Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23912 )
Change subject: IMPALA-14436: Calcite planner: Implement single row join optimization ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/23912/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23912/4//COMMIT_MSG@13 PS4, Line 13: aggregate that produces one row or a values clause. > Would a `limit 1` create the same conditions? Yup, good catch. Added code to handle this and added a test case. -- To view, visit http://gerrit.cloudera.org:8080/23912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755 Gerrit-Change-Number: 23912 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 24 Feb 2026 16:19:46 +0000 Gerrit-HasComments: Yes
