Marton Greber has uploaded this change for review. (
http://gerrit.cloudera.org:8080/24030
Change subject: IMPALA-14777: Sync dynamic_annotations from Kudu
......................................................................
IMPALA-14777: Sync dynamic_annotations from Kudu
be/src/gutil/dynamic_annotations.h was missing Kudu commit a964b0e36
("gutil: properly hook up ANNOTATE_HAPPENS_BEFORE/AFTER", Feb 2018),
which fixed ANNOTATE_HAPPENS_BEFORE and ANNOTATE_HAPPENS_AFTER to use
the proper AnnotateHappensBefore/AnnotateHappensAfter TSAN runtime
functions instead of the condvar-based equivalents.
Also adds the corresponding AnnotateHappensBefore/AnnotateHappensAfter
stub implementations to dynamic_annotations.c, which were missing the
non-TSAN fallback definitions needed when
DYNAMIC_ANNOTATIONS_EXTERNAL_IMPL=0.
Testing: data-stream-test was reporting a TSAN data race on
SignalData::stack in debug-util.cc due to the annotations being
effectively no-ops. Running the test under TSAN with this patch applied
shows the race no longer appears.
Change-Id: I70eda4515cb5e9aed835c371ed3b473e6a9c3ea6
---
M be/src/gutil/dynamic_annotations.c
M be/src/gutil/dynamic_annotations.h
2 files changed, 13 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/24030/1
--
To view, visit http://gerrit.cloudera.org:8080/24030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70eda4515cb5e9aed835c371ed3b473e6a9c3ea6
Gerrit-Change-Number: 24030
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <[email protected]>
