Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24032 )
Change subject: IMPALA-14781: Use real host name in URL in dual stack webui ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24032/2/tests/custom_cluster/test_ipv6.py File tests/custom_cluster/test_ipv6.py: http://gerrit.cloudera.org:8080/#/c/24032/2/tests/custom_cluster/test_ipv6.py@125 PS2, Line 125: assert re.search(r'href="https?://.+:', html_resp) > Should this assert the start of a hostname, i.e. alphanumeric character aft My plan was to match that too and then rule it out in the next assert. For ipv6 ::1 is returned in the test, so that should be accept - it is not a valid value in production, but works for the test. -- To view, visit http://gerrit.cloudera.org:8080/24032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb Gerrit-Change-Number: 24032 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Wed, 25 Feb 2026 17:35:25 +0000 Gerrit-HasComments: Yes
