Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/24059 )
Change subject: IMPALA-14700: Add support for Parquet LZ4_RAW compression ...................................................................... Patch Set 3: (2 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/24059/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24059/3//COMMIT_MSG@19 PS3, Line 19: an existing Parquet file with LZ4_RAW compression Do we have Parquet files with other compressions checked into the repository? Would it make sense to add this file the repo and execute e2e tests with some basic queries on it? http://gerrit.cloudera.org:8080/#/c/24059/3/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/24059/3/bin/impala-config.sh@436 PS3, Line 436: export IMPALA_PARQUET_VERSION=${APACHE_PARQUET_VERSION} I'd prefer a change without the deletions, similar to https://gerrit.cloudera.org/c/23945/7/bin/impala-config.sh It would be a smaller change and more straightforward to revert. -- To view, visit http://gerrit.cloudera.org:8080/24059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22ee4e5bf9abec37be941c1dca8019a563343d34 Gerrit-Change-Number: 24059 Gerrit-PatchSet: 3 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2026 10:21:30 +0000 Gerrit-HasComments: Yes
