[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/23789 )
Change subject: IMPALA-14535: Improve wait for HMS events sync with hierarchical event processing ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/23789/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/23789/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@2021 PS6, Line 2021: String dbName = it.next(); > nit: when removeIf() returns true (meaning something is removed), let's log Done. Have added an initial log to show all db to synchronize. And another log to show a particular db is synced. http://gerrit.cloudera.org:8080/#/c/23789/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@2027 PS6, Line 2027: List<String> tableNames = eventExecutorService_.getTableNames(dbName); > nit: let's also add a similar log here for tables. Done. Have added an initial log to show all tables to synchronize. And another log to show a particular table is synced. http://gerrit.cloudera.org:8080/#/c/23789/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@2034 PS6, Line 2034: } > nit: it'd also be helpful to log a waiting message like the single-threaded Done -- To view, visit http://gerrit.cloudera.org:8080/23789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55cea4cb8e04860202e56e1b1bf2596613b4946c Gerrit-Change-Number: 23789 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2026 13:56:47 +0000 Gerrit-HasComments: Yes
