Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24052 )
Change subject: IMPALA-14792: Try avoiding hadoop.fs.Path when loading Iceberg tables ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/24052/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24052/4//COMMIT_MSG@11 PS4, Line 11: locations must be normalized. Do we see any signs of this ever changing? I assume it'd be pretty visible if it does? http://gerrit.cloudera.org:8080/#/c/24052/4/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java: http://gerrit.cloudera.org:8080/#/c/24052/4/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@a194 PS4, Line 194: I wonder if switching to getRawPath() would have been almost as fast. I don't see it doing much different otherwise. http://gerrit.cloudera.org:8080/#/c/24052/4/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/24052/4/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@356 PS4, Line 356: && path.charAt(tablePathStr_.length()) == '/') { Could tablePathStr_ ever have '/' at the end of it? -- To view, visit http://gerrit.cloudera.org:8080/24052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idce89117195e0fa64fdd6a6c576bce09ec2e75ea Gerrit-Change-Number: 24052 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2026 16:42:39 +0000 Gerrit-HasComments: Yes
