Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24066 )
Change subject: IMPALA-14776 (part 3): Fix misc resource leaks ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24066/1/tests/custom_cluster/test_concurrent_ddls.py File tests/custom_cluster/test_concurrent_ddls.py: http://gerrit.cloudera.org:8080/#/c/24066/1/tests/custom_cluster/test_concurrent_ddls.py@198 PS1, Line 198: pool.terminate() > Should this be in a finally block? "assert False" could fail the test and l IMO we shouldn't add noise with the "with" unless leaking it cause issues. The most sympathetic solution to me would be to add a threadpool fixture to have both minimal noise and proper cleanup -- To view, visit http://gerrit.cloudera.org:8080/24066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee2c7733f477eadac7cde020b9aa47077985eb0d Gerrit-Change-Number: 24066 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 05 Mar 2026 08:13:59 +0000 Gerrit-HasComments: Yes
