Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23994 )
Change subject: IMPALA-14706: Use InMemoryMetricsReporter from the Iceberg 1.4.0 ...................................................................... Patch Set 3: (3 comments) Thanks for the clean-up! http://gerrit.cloudera.org:8080/#/c/23994/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23994/3//COMMIT_MSG@7 PS3, Line 7: 1.4.0 "library" (not the version) http://gerrit.cloudera.org:8080/#/c/23994/3//COMMIT_MSG@9 PS3, Line 9: InMemoryMetricsReporter class is available in the Iceberg library from : release 1.4.0. : : We are dropping the private static InMemoryMetricsReporter class from : IcebergScanPlanner and will use the Iceberg's builtin class instead. : : In addition, the scanMetricsResult() method can be dropped and the : relevant method scanMetrics() can be used directly. nit: Please put the emphasis on what this change achieved as a result. e.g. "Since InMemoryMetricsReporter class is available in the Iceberg library from release 1.4.0., there is no need to implement it internally. This change drops the private static implementor class and switches to using Iceberg's builtin InMemoryMetricsReporter class instead." http://gerrit.cloudera.org:8080/#/c/23994/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/23994/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@171 PS3, Line 171: ScanReport report = metricsReporter_.scanReport(); : ScanMetricsResult metricsResult; : if (report == null) { : metricsResult = null; : } else { : metricsResult = report.scanMetrics(); : } This could be extracted to a separate function. -- To view, visit http://gerrit.cloudera.org:8080/23994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a5acb54ad6d4b62ff6da26f250e83068a33d316 Gerrit-Change-Number: 23994 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Fri, 06 Mar 2026 11:44:22 +0000 Gerrit-HasComments: Yes
